EMF Exporter - Initial implementation with Gauge Support #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
changed the title
mxiamxia
reviewed
Jun 27, 2025
Comment on lines
+46
to
+47
| sumData?: number; | ||
| value?: number; |
There was a problem hiding this comment.
I consolidated this into one if they're both just a number value
mxiamxia
reviewed
Jun 27, 2025
| diag.info(`Created log group: ${this.logGroupName}`); | ||
| } catch (e: unknown) { | ||
| if (e instanceof Error && e.name === 'ResourceAlreadyExistsException') { | ||
| diag.info(`Log group ${this.logGroupName} already exists.`); |
mxiamxia
reviewed
Jun 27, 2025
| this.logStreamExists = true; | ||
| } catch (e: unknown) { | ||
| if (e instanceof Error && e.name === 'ResourceAlreadyExistsException') { | ||
| diag.info(`Log stream ${this.logStreamName} already exists.`); |
mxiamxia
reviewed
Jun 27, 2025
Comment on lines
+167
to
+168
| this.logStreamExistsPromise = this.ensureLogGroupExists().then(async () => { | ||
| await this.ensureLogStreamExists(); |
There was a problem hiding this comment.
make log group/stream into lazy creation based on PLE call
|
Closing in favor of: #206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.